Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5374c455 authored by Jamal Hadi Salim's avatar Jamal Hadi Salim Committed by Greg Kroah-Hartman
Browse files

net: sched: atm: dont intepret cls results when asked to drop 



[ Upstream commit a2965c7be0522eaa18808684b7b82b248515511b ]

If asked to drop a packet via TC_ACT_SHOT it is unsafe to assume
res.class contains a valid pointer
Fixes: b0188d4d ("[NET_SCHED]: sch_atm: Lindent")

Signed-off-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent aeb02b6a

net/sched/sch_atm.c

+4 −1
Original line number Diff line number Diff line
@@ -394,10 +394,13 @@ static int atm_tc_enqueue(struct sk_buff *skb, struct Qdisc *sch, 
				result = tcf_classify(skb, fl, &res, true);

				if (result < 0)

					continue;

				if (result == TC_ACT_SHOT)

					goto done;



				flow = (struct atm_flow_data *)res.class;

				if (!flow)

					flow = lookup_flow(sch, res.classid);

				goto done;

				goto drop;

			}

		}

		flow = NULL;