Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 531bc938 authored by Ben Dooks's avatar Ben Dooks Committed by Felipe Balbi
Browse files

usb: gadget: r8a66597-udc: use devm_kzalloc() to allocate driver state 



Update driver to use devm_kzalloc() to make tracking of resources
easier. Also remove the exit point via cleanup as there's no
cleanup necessary from this point now.

As a note, also removes the error print as the allocation calls
produce errors if they do not return memory.

Signed-off-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent f390f57c

drivers/usb/gadget/r8a66597-udc.c

+3 −7
Original line number Diff line number Diff line
@@ -1836,7 +1836,6 @@ static int __exit r8a66597_remove(struct platform_device *pdev) 
		clk_put(r8a66597->clk);

	}



	kfree(r8a66597);

	return 0;

}
@@ -1892,11 +1891,9 @@ static int __init r8a66597_probe(struct platform_device *pdev) 
	}



	/* initialize ucd */

	r8a66597 = kzalloc(sizeof(struct r8a66597), GFP_KERNEL);

	if (r8a66597 == NULL) {

		ret = -ENOMEM;

		goto clean_up;

	}

	r8a66597 = devm_kzalloc(dev, sizeof(struct r8a66597), GFP_KERNEL);

	if (r8a66597 == NULL)

		return -ENOMEM;



	spin_lock_init(&r8a66597->lock);

	platform_set_drvdata(pdev, r8a66597);
@@ -1995,7 +1992,6 @@ static int __init r8a66597_probe(struct platform_device *pdev) 
		if (r8a66597->ep0_req)

			r8a66597_free_request(&r8a66597->ep[0].ep,

						r8a66597->ep0_req);

		kfree(r8a66597);

	}



	return ret;