Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52b4f6e0 authored by Carlos Palminha's avatar Carlos Palminha Committed by Greg Kroah-Hartman
Browse files

staging: fbtft: fix NULL comparison checkpatch warning 



Fixed the following checkpatch warnings (task #10 of eudyptula challenge):
- NULL comparison rewritten to use '!' operator

Signed-off-by: default avatarCarlos Palminha <palminha@synopsys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 259334ed

drivers/staging/fbtft/fbtft_device.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1418,14 +1418,14 @@ static int __init fbtft_device_init(void) 




	/* parse module parameter: gpios */

	/* parse module parameter: gpios */

	while ((p_gpio = strsep(&gpios, ","))) {

	while ((p_gpio = strsep(&gpios, ","))) {

		if (strchr(p_gpio, ':') == NULL) {

		if (!strchr(p_gpio, ':')) {

			pr_err("error: missing ':' in gpios parameter: %s\n",

			pr_err("error: missing ':' in gpios parameter: %s\n",

			       p_gpio);

			       p_gpio);

			return -EINVAL;

			return -EINVAL;

		}

		}

		p_num = p_gpio;

		p_num = p_gpio;

		p_name = strsep(&p_num, ":");

		p_name = strsep(&p_num, ":");

		if (p_name == NULL || p_num == NULL) {

		if (!p_name || !p_num) {

			pr_err("something bad happened parsing gpios parameter: %s\n",

			pr_err("something bad happened parsing gpios parameter: %s\n",

			       p_gpio);

			       p_gpio);

			return -EINVAL;

			return -EINVAL;