Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52a11256 authored by Armin Wolf's avatar Armin Wolf Committed by Greg Kroah-Hartman
Browse files

ACPI: EC: Abort address space access upon error 



[ Upstream commit f6f172dc6a6d7775b2df6adfd1350700e9a847ec ]

When a multi-byte address space access is requested, acpi_ec_read()/
acpi_ec_write() is being called multiple times.

Abort such operations if a single call to acpi_ec_read() /
acpi_ec_write() fails, as the data read from / written to the EC
might be incomplete.

Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 9656f954

drivers/acpi/ec.c

+4 −1
Original line number Diff line number Diff line
@@ -1330,10 +1330,13 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address, 
	if (ec->busy_polling || bits > 8)

		acpi_ec_burst_enable(ec);



	for (i = 0; i < bytes; ++i, ++address, ++value)

	for (i = 0; i < bytes; ++i, ++address, ++value) {

		result = (function == ACPI_READ) ?

			acpi_ec_read(ec, address, value) :

			acpi_ec_write(ec, address, *value);

		if (result < 0)

			break;

	}



	if (ec->busy_polling || bits > 8)

		acpi_ec_burst_disable(ec);