Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5293bf97 authored by Gavin Shan's avatar Gavin Shan Committed by Benjamin Herrenschmidt
Browse files

powerpc/eeh: Reorder output messages 



We already had some output messages from EEH core. Occasionally,
we can see the output messages from EEH core before the stack
dump. That's not what we expected. The patch fixes that and shows
the stack dump prior to output messages from EEH core.

Signed-off-by: default avatarGavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 8c6852e0

arch/powerpc/kernel/eeh.c

+3 −3
Original line number Diff line number Diff line
@@ -327,11 +327,11 @@ static int eeh_phb_check_failure(struct eeh_pe *pe) 
	/* Isolate the PHB and send event */

	eeh_pe_state_mark(phb_pe, EEH_PE_ISOLATED);

	eeh_serialize_unlock(flags);

	eeh_send_failure_event(phb_pe);



	pr_err("EEH: PHB#%x failure detected\n",

		phb_pe->phb->global_number);

	dump_stack();

	eeh_send_failure_event(phb_pe);



	return 1;

out:
@@ -454,8 +454,6 @@ int eeh_dev_check_failure(struct eeh_dev *edev) 
	eeh_pe_state_mark(pe, EEH_PE_ISOLATED);

	eeh_serialize_unlock(flags);



	eeh_send_failure_event(pe);



	/* Most EEH events are due to device driver bugs.  Having

	 * a stack trace will help the device-driver authors figure

	 * out what happened.  So print that out.
@@ -464,6 +462,8 @@ int eeh_dev_check_failure(struct eeh_dev *edev) 
		pe->addr, pe->phb->global_number);

	dump_stack();



	eeh_send_failure_event(pe);



	return 1;



dn_unlock: