Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 524522c4 authored by Igor Mitsyanko's avatar Igor Mitsyanko Committed by Kalle Valo
Browse files

qtnfmac: get rid of QTNF_STATE_AP_CONFIG 



QTNF_STATE_AP_CONFIG is redundant and its usage can be safely removed.

Signed-off-by: default avatarIgor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent f99201cb

drivers/net/wireless/quantenna/qtnfmac/cfg80211.c

+0 −8
Original line number Diff line number Diff line
@@ -275,13 +275,6 @@ static int qtnf_start_ap(struct wiphy *wiphy, struct net_device *dev, 
		goto out;

	}



	if (!(vif->bss_status & QTNF_STATE_AP_CONFIG)) {

		pr_err("VIF%u.%u: AP config failed in FW\n", vif->mac->macid,

		       vif->vifid);

		ret = -EFAULT;

		goto out;

	}



	ret = qtnf_mgmt_set_appie(vif, &settings->beacon);

	if (ret) {

		pr_err("VIF%u.%u: failed to add IEs to beacon\n",
@@ -316,7 +309,6 @@ static int qtnf_stop_ap(struct wiphy *wiphy, struct net_device *dev) 
		pr_err("VIF%u.%u: failed to stop AP operation in FW\n",

		       vif->mac->macid, vif->vifid);

		vif->bss_status &= ~QTNF_STATE_AP_START;

		vif->bss_status &= ~QTNF_STATE_AP_CONFIG;



		netif_carrier_off(vif->netdev);

	}

drivers/net/wireless/quantenna/qtnfmac/commands.c

+0 −3
Original line number Diff line number Diff line
@@ -256,8 +256,6 @@ int qtnf_cmd_send_config_ap(struct qtnf_vif *vif, 
		goto out;

	}



	vif->bss_status |= QTNF_STATE_AP_CONFIG;



out:

	qtnf_bus_unlock(vif->mac->bus);

	return ret;
@@ -290,7 +288,6 @@ int qtnf_cmd_send_stop_ap(struct qtnf_vif *vif) 
	}



	vif->bss_status &= ~QTNF_STATE_AP_START;

	vif->bss_status &= ~QTNF_STATE_AP_CONFIG;



	netif_carrier_off(vif->netdev);

drivers/net/wireless/quantenna/qtnfmac/core.h

+0 −1
Original line number Diff line number Diff line
@@ -52,7 +52,6 @@ 
#define QTNF_DEF_WDOG_TIMEOUT		5

#define QTNF_TX_TIMEOUT_TRSHLD		100



#define QTNF_STATE_AP_CONFIG		BIT(2)

#define QTNF_STATE_AP_START		BIT(1)



extern const struct net_device_ops qtnf_netdev_ops;