Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51e23be2 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

[media] gspca - main: isoc mode devices are never low speed 



Quoting from the official usb 20 spec:
"5.6.4 Isochronous Transfer Bus Access Constraints

Isochronous transfers can only be used by full-speed and high-speed devices."

This means that for code paths which are isoc mode only, we don't need to
check for the device being low speed, simplifying the code.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarJean-François Moine <moinejf@free.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2d39059a

drivers/media/video/gspca/gspca.c

+1 −4
Original line number Original line Diff line number Diff line
@@ -818,9 +818,6 @@ static int create_urbs(struct gspca_dev *gspca_dev, 
						    ep->desc.bEndpointAddress);

						    ep->desc.bEndpointAddress);

			urb->transfer_flags = URB_ISO_ASAP

			urb->transfer_flags = URB_ISO_ASAP

					| URB_NO_TRANSFER_DMA_MAP;

					| URB_NO_TRANSFER_DMA_MAP;

			if (gspca_dev->dev->speed == USB_SPEED_LOW)

				urb->interval = ep->desc.bInterval;

			else

			urb->interval = 1 << (ep->desc.bInterval - 1);

			urb->interval = 1 << (ep->desc.bInterval - 1);

			urb->complete = isoc_irq;

			urb->complete = isoc_irq;

			urb->number_of_packets = npkt;

			urb->number_of_packets = npkt;