Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 513674b5 authored by Shaohua Li's avatar Shaohua Li Committed by David S. Miller
Browse files

net: reevalulate autoflowlabel setting after sysctl setting 



sysctl.ip6.auto_flowlabels is default 1. In our hosts, we set it to 2.
If sockopt doesn't set autoflowlabel, outcome packets from the hosts are
supposed to not include flowlabel. This is true for normal packet, but
not for reset packet.

The reason is ipv6_pinfo.autoflowlabel is set in sock creation. Later if
we change sysctl.ip6.auto_flowlabels, the ipv6_pinfo.autoflowlabel isn't
changed, so the sock will keep the old behavior in terms of auto
flowlabel. Reset packet is suffering from this problem, because reset
packet is sent from a special control socket, which is created at boot
time. Since sysctl.ipv6.auto_flowlabels is 1 by default, the control
socket will always have its ipv6_pinfo.autoflowlabel set, even after
user set sysctl.ipv6.auto_flowlabels to 1, so reset packset will always
have flowlabel. Normal sock created before sysctl setting suffers from
the same issue. We can't even turn off autoflowlabel unless we kill all
socks in the hosts.

To fix this, if IPV6_AUTOFLOWLABEL sockopt is used, we use the
autoflowlabel setting from user, otherwise we always call
ip6_default_np_autolabel() which has the new settings of sysctl.

Note, this changes behavior a little bit. Before commit 42240901
(ipv6: Implement different admin modes for automatic flow labels), the
autoflowlabel behavior of a sock isn't sticky, eg, if sysctl changes,
existing connection will change autoflowlabel behavior. After that
commit, autoflowlabel behavior is sticky in the whole life of the sock.
With this patch, the behavior isn't sticky again.

Cc: Martin KaFai Lau <kafai@fb.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tom Herbert <tom@quantonium.net>
Signed-off-by: default avatarShaohua Li <shli@fb.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c48e7473

include/linux/ipv6.h

+2 −1
Original line number Diff line number Diff line
@@ -273,7 +273,8 @@ struct ipv6_pinfo { 
						 * 100: prefer care-of address

						 */

				dontfrag:1,

				autoflowlabel:1;

				autoflowlabel:1,

				autoflowlabel_set:1;

	__u8			min_hopcount;

	__u8			tclass;

	__be32			rcv_flowinfo;

net/ipv6/af_inet6.c

+0 −1
Original line number Diff line number Diff line
@@ -210,7 +210,6 @@ static int inet6_create(struct net *net, struct socket *sock, int protocol, 
	np->mcast_hops	= IPV6_DEFAULT_MCASTHOPS;

	np->mc_loop	= 1;

	np->pmtudisc	= IPV6_PMTUDISC_WANT;

	np->autoflowlabel = ip6_default_np_autolabel(net);

	np->repflow	= net->ipv6.sysctl.flowlabel_reflect;

	sk->sk_ipv6only	= net->ipv6.sysctl.bindv6only;

net/ipv6/ip6_output.c

+10 −2
Original line number Diff line number Diff line
@@ -166,6 +166,14 @@ int ip6_output(struct net *net, struct sock *sk, struct sk_buff *skb) 
			    !(IP6CB(skb)->flags & IP6SKB_REROUTED));

}



static bool ip6_autoflowlabel(struct net *net, const struct ipv6_pinfo *np)

{

	if (!np->autoflowlabel_set)

		return ip6_default_np_autolabel(net);

	else

		return np->autoflowlabel;

}



/*

 * xmit an sk_buff (used by TCP, SCTP and DCCP)

 * Note : socket lock is not held for SYNACK packets, but might be modified
@@ -230,7 +238,7 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6, 
		hlimit = ip6_dst_hoplimit(dst);



	ip6_flow_hdr(hdr, tclass, ip6_make_flowlabel(net, skb, fl6->flowlabel,

						     np->autoflowlabel, fl6));

				ip6_autoflowlabel(net, np), fl6));



	hdr->payload_len = htons(seg_len);

	hdr->nexthdr = proto;
@@ -1626,7 +1634,7 @@ struct sk_buff *__ip6_make_skb(struct sock *sk, 


	ip6_flow_hdr(hdr, v6_cork->tclass,

		     ip6_make_flowlabel(net, skb, fl6->flowlabel,

					np->autoflowlabel, fl6));

					ip6_autoflowlabel(net, np), fl6));

	hdr->hop_limit = v6_cork->hop_limit;

	hdr->nexthdr = proto;

	hdr->saddr = fl6->saddr;

net/ipv6/ipv6_sockglue.c

+1 −0
Original line number Diff line number Diff line
@@ -886,6 +886,7 @@ static int do_ipv6_setsockopt(struct sock *sk, int level, int optname, 
		break;

	case IPV6_AUTOFLOWLABEL:

		np->autoflowlabel = valbool;

		np->autoflowlabel_set = 1;

		retv = 0;

		break;

	case IPV6_RECVFRAGSIZE: