Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50b39608 authored by Fabrice Gasnier's avatar Fabrice Gasnier Committed by Jonathan Cameron
Browse files

iio: trigger: stm32-timer: fix quadrature mode get routine 



Fixes: 4adec7da ("iio: stm32 trigger: Add quadrature encoder device")

SMS bitfiled is mode + 1. After reset, upon boot, SMS = 0. When reading
from sysfs, stm32_get_quadrature_mode() returns -1 (e.g. -EPERM) which is
wrong error code here. So, check SMS bitfiled matches valid encoder mode,
or return -EINVAL.

Signed-off-by: default avatarFabrice Gasnier <fabrice.gasnier@st.com>
Acked-by: default avatarBenjamin Gaignard <benjamin.gaignard@linaro.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent eb92b418

drivers/iio/trigger/stm32-timer-trigger.c

+5 −2
Original line number Diff line number Diff line
@@ -571,11 +571,14 @@ static int stm32_get_quadrature_mode(struct iio_dev *indio_dev, 
{

	struct stm32_timer_trigger *priv = iio_priv(indio_dev);

	u32 smcr;

	int mode;



	regmap_read(priv->regmap, TIM_SMCR, &smcr);

	smcr &= TIM_SMCR_SMS;

	mode = (smcr & TIM_SMCR_SMS) - 1;

	if ((mode < 0) || (mode > ARRAY_SIZE(stm32_quadrature_modes)))

		return -EINVAL;



	return smcr - 1;

	return mode;

}



static const struct iio_enum stm32_quadrature_mode_enum = {