Commit 50462ce0 authored Feb 20, 2015 by Fabian Frederick Committed by David S. Miller Feb 22, 2015

hso: replace current->state by __set_current_state()



Use helper functions to access current->state.
Direct assignments are prone to races and therefore buggy.

Thanks to Peter Zijlstra for the exact definition of the problem.

Suggested-By: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 45cee4f5

drivers/net/usb/hso.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1594,7 +1594,7 @@ hso_wait_modem_status(struct hso_serial *serial, unsigned long arg)
		}
		cprev = cnow;
		}
		current->state = TASK_RUNNING;
		__set_current_state(TASK_RUNNING);
		remove_wait_queue(&tiocmget->waitq, &wait);

		return ret;