Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 501a708f authored by Srivatsa S. Bhat's avatar Srivatsa S. Bhat Committed by Rafael J. Wysocki
Browse files

PM / Suspend: Fix bug in suspend statistics update 



After commit 2a77c46d
(PM / Suspend: Add statistics debugfs file for suspend to RAM)
a missing pair of braces inside the state_store() function causes even
invalid arguments to suspend to be wrongly treated as failed suspend
attempts. Fix this.

[rjw: Put the hash/subject of the buggy commit into the changelog.]

Signed-off-by: default avatarSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
parent aa9a7b11

kernel/power/main.c

+2 −1
Original line number Diff line number Diff line
@@ -290,13 +290,14 @@ static ssize_t state_store(struct kobject *kobj, struct kobj_attribute *attr, 
		if (*s && len == strlen(*s) && !strncmp(buf, *s, len))

			break;

	}

	if (state < PM_SUSPEND_MAX && *s)

	if (state < PM_SUSPEND_MAX && *s) {

		error = enter_state(state);

		if (error) {

			suspend_stats.fail++;

			dpm_save_failed_errno(error);

		} else

			suspend_stats.success++;

	}

#endif



 Exit: