Commit 50163475 authored Nov 30, 2016 by Dan Carpenter Committed by Rafael J. Wysocki Nov 30, 2016

ACPI / CPPC: set an error code on probe error path

We should return -EINVAL (instead of 0) if get_cpu_device() fails.

Fixes: 158c998e (ACPI / CPPC: add sysfs support to compute delivered performance)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent e5517c2a

drivers/acpi/cppc_acpi.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -784,8 +784,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)

		/* Add per logical CPU nodes for reading its feedback counters. */
		cpu_dev = get_cpu_device(pr->id);
		if (!cpu_dev)
		if (!cpu_dev) {
		ret = -EINVAL;
		goto out_free;
		}

		ret = kobject_init_and_add(&cpc_ptr->kobj, &cppc_ktype, &cpu_dev->kobj,
		"acpi_cppc");