Commit 4e2ca0c9 authored Sep 30, 2019 by Arnaldo Carvalho de Melo Committed by Greg Kroah-Hartman Nov 06, 2019

perf annotate: Fix the signedness of failure returns



[ Upstream commit 28f4417c3333940b242af03d90214f713bbef232 ]

Callers of symbol__annotate() expect a errno value or some other
extended error value range in symbol__strerror_disassemble() to
convert to a proper error string, fix it when propagating a failure to
find the arch specific annotation routines via arch__find(arch_name).

Reported-by: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Cc: Will Deacon <will@kernel.org>
Link: https://lkml.kernel.org/n/tip-o0k6dw7cas0vvmjjvgsyvu1i@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ec783e28

tools/perf/util/annotate.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1875,7 +1875,7 @@ int symbol__annotate(struct symbol sym, struct map map,

		args.arch = arch = arch__find(arch_name);
		if (arch == NULL)
		return -ENOTSUP;
		return ENOTSUP;

		if (parch)
		*parch = arch;