Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ddd0146 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: intel_pstate: Fold intel_pstate_reset_all_pid() into the caller 



There is only one caller of intel_pstate_reset_all_pid(), which is
pid_param_set() used in the debugfs interface only, and having that
code split does not make it particularly convenient to follow.

For this reason, move the body of intel_pstate_reset_all_pid() into
its caller and drop that function.

Also change the loop from for_each_online_cpu() (which is obviously
racy with respect to CPU offline/online) to for_each_possible_cpu(),
so that all PID parameters are reset for all CPUs regardless of their
online/offline status (to prevent, for example, a previously offline
CPU from going online with a stale set of PID parameters).

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5c439053

drivers/cpufreq/intel_pstate.c

+6 −11
Original line number Diff line number Diff line
@@ -576,16 +576,6 @@ static inline void intel_pstate_busy_pid_reset(struct cpudata *cpu) 
	pid_reset(&cpu->pid, pid_params.setpoint, 100, pid_params.deadband, 0);

}



static inline void intel_pstate_reset_all_pid(void)

{

	unsigned int cpu;



	for_each_online_cpu(cpu) {

		if (all_cpu_data[cpu])

			intel_pstate_busy_pid_reset(all_cpu_data[cpu]);

	}

}



static inline void update_turbo_state(void)

{

	u64 misc_en;
@@ -941,9 +931,14 @@ static void intel_pstate_update_policies(void) 
/************************** debugfs begin ************************/

static int pid_param_set(void *data, u64 val)

{

	unsigned int cpu;



	*(u32 *)data = val;

	pid_params.sample_rate_ns = pid_params.sample_rate_ms * NSEC_PER_MSEC;

	intel_pstate_reset_all_pid();

	for_each_possible_cpu(cpu)

		if (all_cpu_data[cpu])

			intel_pstate_busy_pid_reset(all_cpu_data[cpu]);



	return 0;

}