Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d8d18db authored by Filipe Manana's avatar Filipe Manana Committed by Greg Kroah-Hartman
Browse files

btrfs: fix extent buffer leak on failure to copy root 



commit 72c9925f87c8b74f36f8e75a4cd93d964538d3ca upstream.

At btrfs_copy_root(), if the call to btrfs_inc_ref() fails we end up
returning without unlocking and releasing our reference on the extent
buffer named "cow" we previously allocated with btrfs_alloc_tree_block().

So fix that by unlocking the extent buffer and dropping our reference on
it before returning.

Fixes: be20aa9d ("Btrfs: Add mount option to turn off data cow")
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5b1ef696

fs/btrfs/ctree.c

+2 −0
Original line number Diff line number Diff line
@@ -268,6 +268,8 @@ int btrfs_copy_root(struct btrfs_trans_handle *trans, 
	else

		ret = btrfs_inc_ref(trans, root, cow, 0);

	if (ret) {

		btrfs_tree_unlock(cow);

		free_extent_buffer(cow);

		btrfs_abort_transaction(trans, ret);

		return ret;

	}