Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c61f678 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: drivers/media/video/pvrusb2: Add missing mutex_unlock 

Add a mutex_unlock missing on the error path.  In the other functions in
the same file the locks and unlocks of this mutex appear to be balanced,
so it would seem that the same should hold in this case.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E1;
@@

* mutex_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* mutex_unlock(E1,...);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDouglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a3b1dc95

drivers/media/video/pvrusb2/pvrusb2-ioread.c

+4 −1
Original line number Diff line number Diff line
@@ -223,7 +223,10 @@ int pvr2_ioread_setup(struct pvr2_ioread *cp,struct pvr2_stream *sp) 
				   " pvr2_ioread_setup (setup) id=%p",cp);

			pvr2_stream_kill(sp);

			ret = pvr2_stream_set_buffer_count(sp,BUFFER_COUNT);

			if (ret < 0) return ret;

			if (ret < 0) {

				mutex_unlock(&cp->mutex);

				return ret;

			}

			for (idx = 0; idx < BUFFER_COUNT; idx++) {

				bp = pvr2_stream_get_buffer(sp,idx);

				pvr2_buffer_set_buffer(bp,