Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c3da220 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by James Morris
Browse files

sysfs: Don't leak secdata when a sysfs_dirent is freed. 



While refreshing my sysfs patches I noticed a leak in the secdata
implementation.  We don't free the secdata when we free the
sysfs dirent.

This is a bug in 2.6.32-rc5 that we really should close.

Signed-off-by: default avatarEric W. Biederman <ebiederm@aristanetworks.com>
Acked-by: default avatarSerge Hallyn <serue@us.ibm.com>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 91d3f9ba

fs/sysfs/dir.c

+4 −0
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ 
#include <linux/completion.h>

#include <linux/mutex.h>

#include <linux/slab.h>

#include <linux/security.h>

#include "sysfs.h"



DEFINE_MUTEX(sysfs_mutex);
@@ -285,6 +286,9 @@ void release_sysfs_dirent(struct sysfs_dirent * sd) 
		sysfs_put(sd->s_symlink.target_sd);

	if (sysfs_type(sd) & SYSFS_COPY_NAME)

		kfree(sd->s_name);

	if (sd->s_iattr && sd->s_iattr->ia_secdata)

		security_release_secctx(sd->s_iattr->ia_secdata,

					sd->s_iattr->ia_secdata_len);

	kfree(sd->s_iattr);

	sysfs_free_ino(sd->s_ino);

	kmem_cache_free(sysfs_dir_cachep, sd);