Commit 4bcb8232 authored Apr 07, 2014 by Oleg Nesterov Committed by Linus Torvalds Apr 07, 2014

exit: move check_stack_usage() to the end of do_exit()



It is not clear why check_stack_usage() is called so early and thus it
never checks the stack usage in, say, exit_notify() or
flush_ptrace_hw_breakpoint() or other functions which are only called by
do_exit().

Move the callsite down to the last preempt_disable/schedule.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c39df5fa

kernel/exit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -788,7 +788,6 @@ void do_exit(long code)
		disassociate_ctty(1);
		exit_task_namespaces(tsk);
		exit_task_work(tsk);
		check_stack_usage();
		exit_thread();

		/*
		@@ -842,6 +841,7 @@ void do_exit(long code)

		validate_creds_for_do_exit(tsk);

		check_stack_usage();
		preempt_disable();
		if (tsk->nr_dirtied)
		__this_cpu_add(dirty_throttle_leaks, tsk->nr_dirtied);