Commit 4b8c7bce authored Sep 14, 2018 by Suman Anna Committed by Greg Kroah-Hartman Nov 24, 2019

remoteproc: Check for NULL firmwares in sysfs interface



[ Upstream commit faeadbb64094757150a8c2a3175ca418dbdd472c ]

The remoteproc framework provides a sysfs file 'firmware'
for modifying the firmware image name from userspace. Add
an additional check to ensure NULL firmwares are errored
out right away, rather than getting a delayed error while
requesting a firmware during the start of a remoteproc
later on.

Tested-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e4aecc15

drivers/remoteproc/remoteproc_sysfs.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -48,6 +48,11 @@ static ssize_t firmware_store(struct device *dev,
		}

		len = strcspn(buf, "\n");
		if (!len) {
		dev_err(dev, "can't provide a NULL firmware\n");
		err = -EINVAL;
		goto out;
		}

		p = kstrndup(buf, len, GFP_KERNEL);
		if (!p) {