Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b745b1e authored by Jani Nikula's avatar Jani Nikula Committed by Daniel Vetter
Browse files

drm/i915/sdvo: kfree the intel_sdvo_connector, not drm_connector, on destroy 



Since the base fields in both struct intel_connector and struct
intel_sdvo_connector are at the beginning of the enclosing struct, the
pointers are essentially the same, but there is no requirement or guarantee
that this is always the case. Kfree the enclosing intel_sdvo_connector
pointer that was originally allocated, not the enclosed drm_connector, in
case someone ever rearranges the structs.

Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 662595df

drivers/gpu/drm/i915/intel_sdvo.c

+1 −1
Original line number Diff line number Diff line
@@ -1832,7 +1832,7 @@ static void intel_sdvo_destroy(struct drm_connector *connector) 
	intel_sdvo_destroy_enhance_property(connector);

	drm_sysfs_connector_remove(connector);

	drm_connector_cleanup(connector);

	kfree(connector);

	kfree(intel_sdvo_connector);

}



static bool intel_sdvo_detect_hdmi_audio(struct drm_connector *connector)