Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b40571e authored by Johannes Berg's avatar Johannes Berg Committed by Luca Coelho
Browse files

iwlwifi: mvm: align copy-break SKB payload for MQ RX 



When a small frame is copied completely into the skb->head, the code
doesn't take alignment into account, making mac80211 copy it again
later on architectures that need the alignment. Avoid this by taking
the PAD flag from the device into account when copying.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 94c3e614

drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

+10 −1
Original line number Diff line number Diff line
@@ -149,8 +149,17 @@ static void iwl_mvm_create_skb(struct sk_buff *skb, struct ieee80211_hdr *hdr, 
	unsigned int headlen, fraglen, pad_len = 0;

	unsigned int hdrlen = ieee80211_hdrlen(hdr->frame_control);



	if (desc->mac_flags2 & IWL_RX_MPDU_MFLG2_PAD)

	if (desc->mac_flags2 & IWL_RX_MPDU_MFLG2_PAD) {

		pad_len = 2;



		/*

		 * If the device inserted padding it means that (it thought)

		 * the 802.11 header wasn't a multiple of 4 bytes long. In

		 * this case, reserve two bytes at the start of the SKB to

		 * align the payload properly in case we end up copying it.

		 */

		skb_reserve(skb, pad_len);

	}

	len -= pad_len;



	/* If frame is small enough to fit in skb->head, pull it completely.