Commit 4b380a7d authored Jun 03, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Jun 16, 2021

NFS: Fix a potential NULL dereference in nfs_get_client()



[ Upstream commit 09226e8303beeec10f2ff844d2e46d1371dc58e0 ]

None of the callers are expecting NULL returns from nfs_get_client() so
this code will lead to an Oops.  It's better to return an error
pointer.  I expect that this is dead code so hopefully no one is
affected.

Fixes: 31434f49 ("nfs: check hostname in nfs_get_client")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1ec2dcd6

fs/nfs/client.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -407,7 +407,7 @@ struct nfs_client nfs_get_client(const struct nfs_client_initdata cl_init)

		if (cl_init->hostname == NULL) {
		WARN_ON(1);
		return NULL;
		return ERR_PTR(-EINVAL);
		}

		/* see if the client already exists */