Commit 4affbe1d authored Dec 05, 2014 by Antti Palosaari Committed by Mauro Carvalho Chehab Jan 29, 2015

[media] si2168: simplify si2168_cmd_execute() error path



Remove if () from firmware command error path as there should not be
any error prone conditional logic there. Use goto labels instead.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent 3de35835

drivers/media/dvb-frontends/si2168.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -66,15 +66,11 @@ static int si2168_cmd_execute(struct i2c_client client, struct si2168_cmd cmd)
		}
		}

		ret = 0;
		mutex_unlock(&dev->i2c_mutex);
		return 0;

		err_mutex_unlock:
		mutex_unlock(&dev->i2c_mutex);
		if (ret)
		goto err;

		return 0;
		err:
		dev_dbg(&client->dev, "failed=%d\n", ret);
		return ret;
		}