Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4acd5ade authored by Michael Straube's avatar Michael Straube Committed by Greg Kroah-Hartman
Browse files

staging: pi433: fix potential null dereference 



[ Upstream commit 64c4c4ca6c129a4191e8e1e91b2d5d9b8d08c518 ]

Add a test for successful call to cdev_alloc() to avoid
potential null dereference. Issue reported by smatch.

Signed-off-by: default avatarMichael Straube <straube.linux@gmail.com>
Fixes: 874bcba6 ("staging: pi433: New driver")
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6eaf5b9e

drivers/staging/pi433/pi433_if.c

+4 −0
Original line number Diff line number Diff line
@@ -1255,6 +1255,10 @@ static int pi433_probe(struct spi_device *spi) 


	/* create cdev */

	device->cdev = cdev_alloc();

	if (!device->cdev) {

		dev_dbg(device->dev, "allocation of cdev failed");

		goto cdev_failed;

	}

	device->cdev->owner = THIS_MODULE;

	cdev_init(device->cdev, &pi433_fops);

	retval = cdev_add(device->cdev, device->devt, 1);