Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a5a4184 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Bryan Wu
Browse files

leds: renesas: fix error handling 



bfe4c041 "leds: convert Renesas TPU LED driver to devm_kzalloc() and
cleanup error exit path" introduced a possible case in which r_tpu_probe
calls iounmap on a wild pointer. This changes the one case that was
missed in the same way as the other error paths.

Without this patch, building kota2_defconfig results in:

drivers/leds/leds-renesas-tpu.c: In function 'r_tpu_probe':
drivers/leds/leds-renesas-tpu.c:246:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
drivers/leds/leds-renesas-tpu.c:308:17: warning: 'p' may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: Magnus Damm <damm@opensource.se>
Signed-off-by: default avatarBryan Wu <bryan.wu@canonical.com>
parent 86e99d23

drivers/leds/leds-renesas-tpu.c

+1 −1
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ static int __devinit r_tpu_probe(struct platform_device *pdev) 


	if (!cfg) {

		dev_err(&pdev->dev, "missing platform data\n");

		goto err0;

		return -ENODEV;

	}



	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);