Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a23fc8c authored by Zhouyang Jia's avatar Zhouyang Jia Committed by Takashi Iwai
Browse files

ALSA: lx6464es: add error handling for pci_ioremap_bar 



When pci_ioremap_bar fails, the lack of error-handling code may
cause unexpected results.

This patch adds error-handling code after calling pci_ioremap_bar.

Signed-off-by: default avatarZhouyang Jia <jiazhouyang09@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 41538f2d

sound/pci/lx6464es/lx6464es.c

+7 −0
Original line number Diff line number Diff line
@@ -1016,6 +1016,10 @@ static int snd_lx6464es_create(struct snd_card *card, 


	/* dsp port */

	chip->port_dsp_bar = pci_ioremap_bar(pci, 2);

	if (!chip->port_dsp_bar) {

		dev_err(card->dev, "cannot remap PCI memory region\n");

		goto remap_pci_failed;

	}



	err = request_threaded_irq(pci->irq, lx_interrupt, lx_threaded_irq,

				   IRQF_SHARED, KBUILD_MODNAME, chip);
@@ -1055,6 +1059,9 @@ static int snd_lx6464es_create(struct snd_card *card, 
	free_irq(pci->irq, chip);



request_irq_failed:

	iounmap(chip->port_dsp_bar);



remap_pci_failed:

	pci_release_regions(pci);



request_regions_failed: