Commit 4a0d2eee authored Jul 31, 2019 by Qian Cai Committed by Greg Kroah-Hartman Aug 25, 2019

arm64/mm: fix variable 'pud' set but not used



[ Upstream commit 7d4e2dcf311d3b98421d1f119efe5964cafa32fc ]

GCC throws a warning,

arch/arm64/mm/mmu.c: In function 'pud_free_pmd_page':
arch/arm64/mm/mmu.c:1033:8: warning: variable 'pud' set but not used
[-Wunused-but-set-variable]
  pud_t pud;
        ^~~

because pud_table() is a macro and compiled away. Fix it by making it a
static inline function and for pud_sect() as well.

Signed-off-by: Qian Cai <cai@lca.pw>
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 6af9263f

arch/arm64/include/asm/pgtable.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -419,8 +419,8 @@ extern pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
		PMD_TYPE_SECT)

		#if defined(CONFIG_ARM64_64K_PAGES) \|\| CONFIG_PGTABLE_LEVELS < 3
		#define pud_sect(pud) (0)
		#define pud_table(pud) (1)
		static inline bool pud_sect(pud_t pud) { return false; }
		static inline bool pud_table(pud_t pud) { return true; }
		#else
		#define pud_sect(pud) ((pud_val(pud) & PUD_TYPE_MASK) == \
		PUD_TYPE_SECT)