Commit 49ee23b7 authored Feb 23, 2018 by Geert Uytterhoeven Committed by Greg Kroah-Hartman Feb 28, 2018

serial: samsung: Fix out-of-bounds access through serial port index



The s3c24xx_serial_ports[] array is indexed using a value derived from
the "serialN" alias in DT, or from an incrementing probe index, which
may lead to an out-of-bounds access.

Fix this by adding a range check.

Note that the array size is defined by a Kconfig symbol
(CONFIG_SERIAL_SAMSUNG_UARTS), so this can even be triggered using
a legitimate DTB or legitimate board code.

Fixes: 13a9f6c6 ("serial: samsung: Consider DT alias when probing ports")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent afc7851f

drivers/tty/serial/samsung.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1818,6 +1818,10 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)

		dbg("s3c24xx_serial_probe(%p) %d\n", pdev, index);

		if (index >= ARRAY_SIZE(s3c24xx_serial_ports)) {
		dev_err(&pdev->dev, "serial%d out of range\n", index);
		return -EINVAL;
		}
		ourport = &s3c24xx_serial_ports[index];

		ourport->drv_data = s3c24xx_get_driver_data(pdev);