Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 499b702a authored by David Kilroy's avatar David Kilroy Committed by John W. Linville
Browse files

orinoco: Fix inappropriate use of IRQ_BAP 



This hardware buffer should only be used from an interrupt. The
wireless event generation functions are called from a workqueue, so use
USER_BAP instead.

Signed-off-by: default avatarDavid Kilroy <kilroyd@googlemail.com>
Signed-off-by: default avatarPavel Roskin <proski@gnu.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 0c06dd8a

drivers/net/wireless/orinoco/orinoco.c

+3 −3
Original line number Diff line number Diff line
@@ -1750,7 +1750,7 @@ static void orinoco_send_bssid_wevent(struct orinoco_private *priv) 
	union iwreq_data wrqu;

	int err;



	err = hermes_read_ltv(hw, IRQ_BAP, HERMES_RID_CURRENTBSSID,

	err = hermes_read_ltv(hw, USER_BAP, HERMES_RID_CURRENTBSSID,

			      ETH_ALEN, NULL, wrqu.ap_addr.sa_data);

	if (err != 0)

		return;
@@ -1773,7 +1773,7 @@ static void orinoco_send_assocreqie_wevent(struct orinoco_private *priv) 
	if (!priv->has_wpa)

		return;



	err = hermes_read_ltv(hw, IRQ_BAP, HERMES_RID_CURRENT_ASSOC_REQ_INFO,

	err = hermes_read_ltv(hw, USER_BAP, HERMES_RID_CURRENT_ASSOC_REQ_INFO,

			      sizeof(buf), NULL, &buf);

	if (err != 0)

		return;
@@ -1803,7 +1803,7 @@ static void orinoco_send_assocrespie_wevent(struct orinoco_private *priv) 
	if (!priv->has_wpa)

		return;



	err = hermes_read_ltv(hw, IRQ_BAP, HERMES_RID_CURRENT_ASSOC_RESP_INFO,

	err = hermes_read_ltv(hw, USER_BAP, HERMES_RID_CURRENT_ASSOC_RESP_INFO,

			      sizeof(buf), NULL, &buf);

	if (err != 0)

		return;