Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 496baea0 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Greg Kroah-Hartman
Browse files

Staging: lustre: lov: Pull assignments out of function call 



Assignments in function call arguments are undesirable. So pull such
assignments out before function call.
Made a coccinelle script to detect such cases:
@@
expression fn,b,d;
@@
* fn(...,d=b,...);

Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f51e5a20

drivers/staging/lustre/lustre/lov/lov_merge.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -129,7 +129,8 @@ int lov_adjust_kms(struct obd_export *exp, struct lov_stripe_md *lsm, 
			       "stripe %d KMS %sing %llu->%llu\n",

			       "stripe %d KMS %sing %llu->%llu\n",

			       stripe, kms > loi->loi_kms ? "increase":"shrink",

			       stripe, kms > loi->loi_kms ? "increase":"shrink",

			       loi->loi_kms, kms);

			       loi->loi_kms, kms);

			loi_kms_set(loi, loi->loi_lvb.lvb_size = kms);

			loi->loi_lvb.lvb_size = kms;

			loi_kms_set(loi, loi->loi_lvb.lvb_size);

		}

		}

		return 0;

		return 0;

	}

	}