Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 491762b3 authored by Dongliang Mu's avatar Dongliang Mu Committed by Greg Kroah-Hartman
Browse files

media: pvrusb2: fix memory leak in pvr_probe 



commit 945a9a8e448b65bec055d37eba58f711b39f66f0 upstream.

The error handling code in pvr2_hdw_create forgets to unregister the
v4l2 device. When pvr2_hdw_create returns back to pvr2_context_create,
it calls pvr2_context_destroy to destroy context, but mp->hdw is NULL,
which leads to that pvr2_hdw_destroy directly returns.

Fix this by adding v4l2_device_unregister to decrease the refcount of
usb interface.

Reported-by: default avatar <syzbot+77b432d57c4791183ed4@syzkaller.appspotmail.com>
Signed-off-by: default avatarDongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c20d03b8

drivers/media/usb/pvrusb2/pvrusb2-hdw.c

+1 −0
Original line number Diff line number Diff line
@@ -2602,6 +2602,7 @@ struct pvr2_hdw *pvr2_hdw_create(struct usb_interface *intf, 
		del_timer_sync(&hdw->encoder_run_timer);

		del_timer_sync(&hdw->encoder_wait_timer);

		flush_work(&hdw->workpoll);

		v4l2_device_unregister(&hdw->v4l2_dev);

		usb_free_urb(hdw->ctl_read_urb);

		usb_free_urb(hdw->ctl_write_urb);

		kfree(hdw->ctl_read_buffer);