Commit 49121201 authored Nov 11, 2015 by Dan Carpenter Committed by Martin K. Petersen Nov 11, 2015

mptfusion: don't allow negative bytes in kbuf_alloc_2_sgl()



There is a static checker warning here because "bytes" is controlled by
the user and we cap the upper bound with min() but allow negatives.
Negative bytes will result in some nasty warning messages but are not
super harmful.  Anyway, no one needs negative bytes so let's just check
for it and return NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 9c9bd593

drivers/message/fusion/mptctl.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1038,6 +1038,10 @@ kbuf_alloc_2_sgl(int bytes, u32 sgdir, int sge_offset, int *frags,
		int i, buflist_ent;
		int sg_spill = MAX_FRAGS_SPILL1;
		int dir;

		if (bytes < 0)
		return NULL;

		/* initialization */
		*frags = 0;
		*blp = NULL;