Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48c2567d authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Nicholas Bellinger
Browse files

target: remove ->get_device_rev 



Now that the reservations and ALUA code have been cleaned up there is no need
for the get_device_rev method, as we only need the standards revision in the
inquiry data, where we can hardcode it.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent c87fbd56

drivers/target/target_core_device.c

+0 −2
Original line number Diff line number Diff line
@@ -1348,8 +1348,6 @@ static void scsi_dump_inquiry(struct se_device *dev) 


	device_type = dev->transport->get_device_type(dev);

	pr_debug("  Type:   %s ", scsi_device_type(device_type));

	pr_debug("                 ANSI SCSI revision: %02x\n",

				dev->transport->get_device_rev(dev));

}



struct se_device *target_alloc_device(struct se_hba *hba, const char *name)

drivers/target/target_core_file.c

+0 −1
Original line number Diff line number Diff line
@@ -534,7 +534,6 @@ static struct se_subsystem_api fileio_template = { 
	.parse_cdb		= fd_parse_cdb,

	.set_configfs_dev_params = fd_set_configfs_dev_params,

	.show_configfs_dev_params = fd_show_configfs_dev_params,

	.get_device_rev		= sbc_get_device_rev,

	.get_device_type	= sbc_get_device_type,

	.get_blocks		= fd_get_blocks,

};

drivers/target/target_core_iblock.c

+0 −1
Original line number Diff line number Diff line
@@ -725,7 +725,6 @@ static struct se_subsystem_api iblock_template = { 
	.parse_cdb		= iblock_parse_cdb,

	.set_configfs_dev_params = iblock_set_configfs_dev_params,

	.show_configfs_dev_params = iblock_show_configfs_dev_params,

	.get_device_rev		= sbc_get_device_rev,

	.get_device_type	= sbc_get_device_type,

	.get_blocks		= iblock_get_blocks,

};

drivers/target/target_core_pscsi.c

+0 −13
Original line number Diff line number Diff line
@@ -1106,18 +1106,6 @@ static int pscsi_execute_cmd(struct se_cmd *cmd) 
	return -ENOMEM;

}



/*	pscsi_get_device_rev():

 *

 *

 */

static u32 pscsi_get_device_rev(struct se_device *dev)

{

	struct pscsi_dev_virt *pdv = PSCSI_DEV(dev);

	struct scsi_device *sd = pdv->pdv_sd;



	return (sd->scsi_level - 1) ? sd->scsi_level - 1 : 1;

}



/*	pscsi_get_device_type():

 *

 *
@@ -1187,7 +1175,6 @@ static struct se_subsystem_api pscsi_template = { 
	.parse_cdb		= pscsi_parse_cdb,

	.set_configfs_dev_params = pscsi_set_configfs_dev_params,

	.show_configfs_dev_params = pscsi_show_configfs_dev_params,

	.get_device_rev		= pscsi_get_device_rev,

	.get_device_type	= pscsi_get_device_type,

	.get_blocks		= pscsi_get_blocks,

};

drivers/target/target_core_rd.c

+0 −1
Original line number Diff line number Diff line
@@ -449,7 +449,6 @@ static struct se_subsystem_api rd_mcp_template = { 
	.parse_cdb		= rd_parse_cdb,

	.set_configfs_dev_params = rd_set_configfs_dev_params,

	.show_configfs_dev_params = rd_show_configfs_dev_params,

	.get_device_rev		= sbc_get_device_rev,

	.get_device_type	= sbc_get_device_type,

	.get_blocks		= rd_get_blocks,

};