Commit 48531847 authored Jul 23, 2009 by Johannes Berg Committed by John W. Linville Jul 27, 2009

mac80211: fix mlme timeouts



When a new MLME work is created, its timeout is initialised
to 0. This is wrong, it could then be thought of as having
an actual timeout in the future (time_is_after_jiffies() can
return true). Instead, it should be initialised to jiffies
so that it will run right away as soon as the mlme work is
executed.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Reported-by: Luciano Roth Coelho <luciano.coelho@nokia.com>
Reported-by: Alban Browaeys <prahal@yahoo.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 09f97e0f

net/mac80211/mlme.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2377,6 +2377,7 @@ int ieee80211_mgd_auth(struct ieee80211_sub_if_data *sdata,

		wk->state = IEEE80211_MGD_STATE_PROBE;
		wk->auth_alg = auth_alg;
		wk->timeout = jiffies; /* run right away */

		/*
		* XXX: if still associated need to tell AP that we're going
		@@ -2448,6 +2449,7 @@ int ieee80211_mgd_assoc(struct ieee80211_sub_if_data *sdata,

		wk->state = IEEE80211_MGD_STATE_ASSOC;
		wk->tries = 0;
		wk->timeout = jiffies; /* run right away */

		if (req->use_mfp) {
		ifmgd->mfp = IEEE80211_MFP_REQUIRED;