Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 484c3449 authored by Alban Bedel's avatar Alban Bedel Committed by Ralf Baechle
Browse files

MIPS: FW: Use kstrtoul() to parse unsigned long from the fw environment 



Fix some value corruptions with values that can't be represented in a
signed long.

Signed-off-by: default avatarAlban Bedel <albeu@free.fr>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/8358/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 4a792e56

arch/mips/fw/lib/cmdline.c

+3 −3
Original line number Diff line number Diff line
@@ -88,13 +88,13 @@ unsigned long fw_getenvl(char *envname) 
{

	unsigned long envl = 0UL;

	char *str;

	long val;

	int tmp;



	str = fw_getenv(envname);

	if (str) {

		tmp = kstrtol(str, 0, &val);

		envl = (unsigned long)val;

		tmp = kstrtoul(str, 0, &envl);

		if (tmp)

			envl = 0;

	}



	return envl;