Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4827cc37 authored by Yury Kylulin's avatar Yury Kylulin Committed by Jeff Kirsher
Browse files

igb/igbvf: Add VF MAC filter request capabilities 



Add functionality for the VF to request up to 3 additional MAC filters.
This is done using existing E1000_VF_SET_MAC_ADDR message, but with
additional message info - E1000_VF_MAC_FILTER_CLR to clear all unicast
MAC filters previously set for this VF and E1000_VF_MAC_FILTER_ADD to
add MAC filter.

Additional filters can be added only in case if administrator did not
set VF MAC explicitly and allowed to change default MAC to the VF.

Due to the limited number of RAR entries reserve at least 3 MAC filters
for the PF.

If SRIOV is supported by the NIC after this change RAR entries starting
from 1 to (RAR MAX ENTRIES - NUM SRIOV VFS) will be used for PF and VF
MAC filters.

Signed-off-by: default avatarYury Kylulin <yury.kylulin@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 83c21335

drivers/net/ethernet/intel/igb/e1000_mbx.h

+4 −0
Original line number Diff line number Diff line
@@ -55,6 +55,10 @@ 


#define E1000_VF_RESET		0x01 /* VF requests reset */

#define E1000_VF_SET_MAC_ADDR	0x02 /* VF requests to set MAC addr */

/* VF requests to clear all unicast MAC filters */

#define E1000_VF_MAC_FILTER_CLR	(0x01 << E1000_VT_MSGINFO_SHIFT)

/* VF requests to add unicast MAC filter */

#define E1000_VF_MAC_FILTER_ADD	(0x02 << E1000_VT_MSGINFO_SHIFT)

#define E1000_VF_SET_MULTICAST	0x03 /* VF requests to set MC addr */

#define E1000_VF_SET_VLAN	0x04 /* VF requests to set VLAN */

#define E1000_VF_SET_LPE	0x05 /* VF requests to set VMOLR.LPE */

drivers/net/ethernet/intel/igb/igb.h

+12 −0
Original line number Diff line number Diff line
@@ -111,6 +111,16 @@ struct vf_data_storage { 
	bool spoofchk_enabled;

};



/* Number of unicast MAC filters reserved for the PF in the RAR registers */

#define IGB_PF_MAC_FILTERS_RESERVED	3



struct vf_mac_filter {

	struct list_head l;

	int vf;

	bool free;

	u8 vf_mac[ETH_ALEN];

};



#define IGB_VF_FLAG_CTS            0x00000001 /* VF is clear to send data */

#define IGB_VF_FLAG_UNI_PROMISC    0x00000002 /* VF has unicast promisc */

#define IGB_VF_FLAG_MULTI_PROMISC  0x00000004 /* VF has multicast promisc */
@@ -586,6 +596,8 @@ struct igb_adapter { 
	bool etype_bitmap[MAX_ETYPE_FILTER];



	struct igb_mac_addr *mac_table;

	struct vf_mac_filter vf_macs;

	struct vf_mac_filter *vf_mac_list;

};



/* flags controlling PTP/1588 function */

drivers/net/ethernet/intel/igb/igb_main.c

+134 −13
Original line number Diff line number Diff line
@@ -1158,6 +1158,8 @@ static void igb_set_interrupt_capability(struct igb_adapter *adapter, bool msix) 
		pci_disable_sriov(adapter->pdev);

		msleep(500);



		kfree(adapter->vf_mac_list);

		adapter->vf_mac_list = NULL;

		kfree(adapter->vf_data);

		adapter->vf_data = NULL;

		wr32(E1000_IOVCTL, E1000_IOVCTL_REUSE_VFQ);
@@ -2809,6 +2811,8 @@ static int igb_disable_sriov(struct pci_dev *pdev) 
			msleep(500);

		}



		kfree(adapter->vf_mac_list);

		adapter->vf_mac_list = NULL;

		kfree(adapter->vf_data);

		adapter->vf_data = NULL;

		adapter->vfs_allocated_count = 0;
@@ -2829,8 +2833,9 @@ static int igb_enable_sriov(struct pci_dev *pdev, int num_vfs) 
	struct net_device *netdev = pci_get_drvdata(pdev);

	struct igb_adapter *adapter = netdev_priv(netdev);

	int old_vfs = pci_num_vf(pdev);

	struct vf_mac_filter *mac_list;

	int err = 0;

	int i;

	int num_vf_mac_filters, i;



	if (!(adapter->flags & IGB_FLAG_HAS_MSIX) || num_vfs > 7) {

		err = -EPERM;
@@ -2858,6 +2863,38 @@ static int igb_enable_sriov(struct pci_dev *pdev, int num_vfs) 
		goto out;

	}



	/* Due to the limited number of RAR entries calculate potential

	 * number of MAC filters available for the VFs. Reserve entries

	 * for PF default MAC, PF MAC filters and at least one RAR entry

	 * for each VF for VF MAC.

	 */

	num_vf_mac_filters = adapter->hw.mac.rar_entry_count -

			     (1 + IGB_PF_MAC_FILTERS_RESERVED +

			      adapter->vfs_allocated_count);



	adapter->vf_mac_list = kcalloc(num_vf_mac_filters,

				       sizeof(struct vf_mac_filter),

				       GFP_KERNEL);



	mac_list = adapter->vf_mac_list;

	INIT_LIST_HEAD(&adapter->vf_macs.l);



	if (adapter->vf_mac_list) {

		/* Initialize list of VF MAC filters */

		for (i = 0; i < num_vf_mac_filters; i++) {

			mac_list->vf = -1;

			mac_list->free = true;

			list_add(&mac_list->l, &adapter->vf_macs.l);

			mac_list++;

		}

	} else {

		/* If we could not allocate memory for the VF MAC filters

		 * we can continue without this feature but warn user.

		 */

		dev_err(&pdev->dev,

			"Unable to allocate memory for VF MAC filter list\n");

	}



	/* only call pci_enable_sriov() if no VFs are allocated already */

	if (!old_vfs) {

		err = pci_enable_sriov(pdev, adapter->vfs_allocated_count);
@@ -2874,6 +2911,8 @@ static int igb_enable_sriov(struct pci_dev *pdev, int num_vfs) 
	goto out;



err_out:

	kfree(adapter->vf_mac_list);

	adapter->vf_mac_list = NULL;

	kfree(adapter->vf_data);

	adapter->vf_data = NULL;

	adapter->vfs_allocated_count = 0;
@@ -6501,18 +6540,106 @@ static int igb_uc_unsync(struct net_device *netdev, const unsigned char *addr) 
	return 0;

}



int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,

			  const u32 info, const u8 *addr)

{

	struct pci_dev *pdev = adapter->pdev;

	struct vf_data_storage *vf_data = &adapter->vf_data[vf];

	struct list_head *pos;

	struct vf_mac_filter *entry = NULL;

	int ret = 0;



	switch (info) {

	case E1000_VF_MAC_FILTER_CLR:

		/* remove all unicast MAC filters related to the current VF */

		list_for_each(pos, &adapter->vf_macs.l) {

			entry = list_entry(pos, struct vf_mac_filter, l);

			if (entry->vf == vf) {

				entry->vf = -1;

				entry->free = true;

				igb_del_mac_filter(adapter, entry->vf_mac, vf);

			}

		}

		break;

	case E1000_VF_MAC_FILTER_ADD:

		if (vf_data->flags & IGB_VF_FLAG_PF_SET_MAC) {

			dev_warn(&pdev->dev,

				 "VF %d requested MAC filter but is administratively denied\n",

				 vf);

			return -EINVAL;

		}



		if (!is_valid_ether_addr(addr)) {

			dev_warn(&pdev->dev,

				 "VF %d attempted to set invalid MAC filter\n",

				 vf);

			return -EINVAL;

		}



		/* try to find empty slot in the list */

		list_for_each(pos, &adapter->vf_macs.l) {

			entry = list_entry(pos, struct vf_mac_filter, l);

			if (entry->free)

				break;

		}



		if (entry && entry->free) {

			entry->free = false;

			entry->vf = vf;

			ether_addr_copy(entry->vf_mac, addr);



			ret = igb_add_mac_filter(adapter, addr, vf);

			ret = min_t(int, ret, 0);

		} else {

			ret = -ENOSPC;

		}



		if (ret == -ENOSPC)

			dev_warn(&pdev->dev,

				 "VF %d has requested MAC filter but there is no space for it\n",

				 vf);

		break;

	default:

		ret = -EINVAL;

		break;

	}



	return ret;

}



static int igb_set_vf_mac_addr(struct igb_adapter *adapter, u32 *msg, int vf)

{

	struct pci_dev *pdev = adapter->pdev;

	struct vf_data_storage *vf_data = &adapter->vf_data[vf];

	u32 info = msg[0] & E1000_VT_MSGINFO_MASK;



	/* The VF MAC Address is stored in a packed array of bytes

	 * starting at the second 32 bit word of the msg array

	 */

	unsigned char *addr = (char *)&msg[1];

	int err = -1;

	unsigned char *addr = (unsigned char *)&msg[1];

	int ret = 0;



	if (!info) {

		if (vf_data->flags & IGB_VF_FLAG_PF_SET_MAC) {

			dev_warn(&pdev->dev,

				 "VF %d attempted to override administratively set MAC address\nReload the VF driver to resume operations\n",

				 vf);

			return -EINVAL;

		}



	if (is_valid_ether_addr(addr))

		err = igb_set_vf_mac(adapter, vf, addr);

		if (!is_valid_ether_addr(addr)) {

			dev_warn(&pdev->dev,

				 "VF %d attempted to set invalid MAC\n",

				 vf);

			return -EINVAL;

		}



	return err;

		ret = igb_set_vf_mac(adapter, vf, addr);

	} else {

		ret = igb_set_vf_mac_filter(adapter, vf, info, addr);

	}



	return ret;

}



static void igb_rcv_ack_from_vf(struct igb_adapter *adapter, u32 vf)
@@ -6569,13 +6696,7 @@ static void igb_rcv_msg_from_vf(struct igb_adapter *adapter, u32 vf) 


	switch ((msgbuf[0] & 0xFFFF)) {

	case E1000_VF_SET_MAC_ADDR:

		retval = -EINVAL;

		if (!(vf_data->flags & IGB_VF_FLAG_PF_SET_MAC))

		retval = igb_set_vf_mac_addr(adapter, msgbuf, vf);

		else

			dev_warn(&pdev->dev,

				 "VF %d attempted to override administratively set MAC address\nReload the VF driver to resume operations\n",

				 vf);

		break;

	case E1000_VF_SET_PROMISC:

		retval = igb_set_vf_promisc(adapter, msgbuf, vf);

drivers/net/ethernet/intel/igbvf/igbvf.h

+2 −0
Original line number Diff line number Diff line
@@ -101,6 +101,8 @@ enum latency_range { 


#define IGBVF_MNG_VLAN_NONE	(-1)



#define IGBVF_MAX_MAC_FILTERS	3



/* Number of packet split data buffers (not including the header buffer) */

#define PS_PAGE_BUFFERS		(MAX_PS_BUFFERS - 1)

drivers/net/ethernet/intel/igbvf/mbx.h

+4 −0
Original line number Diff line number Diff line
@@ -62,6 +62,10 @@ 


#define E1000_VF_RESET		0x01 /* VF requests reset */

#define E1000_VF_SET_MAC_ADDR	0x02 /* VF requests PF to set MAC addr */

/* VF requests PF to clear all unicast MAC filters */

#define E1000_VF_MAC_FILTER_CLR (0x01 << E1000_VT_MSGINFO_SHIFT)

/* VF requests PF to add unicast MAC filter */

#define E1000_VF_MAC_FILTER_ADD (0x02 << E1000_VT_MSGINFO_SHIFT)

#define E1000_VF_SET_MULTICAST	0x03 /* VF requests PF to set MC addr */

#define E1000_VF_SET_VLAN	0x04 /* VF requests PF to set VLAN */

#define E1000_VF_SET_LPE	0x05 /* VF requests PF to set VMOLR.LPE */