Commit 47ebea83 authored Mar 22, 2007 by Adrian Bunk Committed by Linus Torvalds Mar 22, 2007

[PATCH] drivers/video/s3fb.c: fix a use-before-check



NULL checks should be before the first dereference.

Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Ondrej Zajicek <santiago@crfreenet.org>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent fffda91e

drivers/video/s3fb.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1000,11 +1000,12 @@ static int __devinit s3_pci_probe(struct pci_dev *dev, const struct pci_device_i
		static void __devexit s3_pci_remove(struct pci_dev *dev)
		{
		struct fb_info *info = pci_get_drvdata(dev);
		struct s3fb_info *par = info->par;

		if (info) {

		#ifdef CONFIG_MTRR
		struct s3fb_info *par = info->par;

		if (par->mtrr_reg >= 0) {
		mtrr_del(par->mtrr_reg, 0, 0);
		par->mtrr_reg = -1;