Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47cd4b3c authored by Asai Thambi S P's avatar Asai Thambi S P Committed by Jens Axboe
Browse files

mtip32xx: fix for driver hang after a command timeout 



If an I/O command times out when a PIO command is active,
MTIP_PF_EH_ACTIVE_BIT is not cleared. This results in I/O
hang in the driver. Fix is to clear this bit.

Signed-off-by: default avatarAsai Thambi S P <asamymuthupa@micron.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent b6c46cfa

drivers/block/mtip32xx/mtip32xx.c

+5 −4
Original line number Diff line number Diff line
@@ -626,13 +626,14 @@ static void mtip_timeout_function(unsigned long int data) 
		}

	}



	if (cmdto_cnt && !test_bit(MTIP_PF_IC_ACTIVE_BIT, &port->flags)) {

	if (cmdto_cnt) {

		print_tags(port->dd, "timed out", tagaccum, cmdto_cnt);



		if (!test_bit(MTIP_PF_IC_ACTIVE_BIT, &port->flags)) {

			mtip_restart_port(port);

		clear_bit(MTIP_PF_EH_ACTIVE_BIT, &port->flags);

			wake_up_interruptible(&port->svc_wait);

		}

		clear_bit(MTIP_PF_EH_ACTIVE_BIT, &port->flags);

	}



	if (port->ic_pause_timer) {

		to  = port->ic_pause_timer + msecs_to_jiffies(1000);