Commit 47b586f6 authored May 07, 2017 by Colin Ian King Committed by Mauro Carvalho Chehab Jun 07, 2017

[media] pvrusb2: remove redundant check on cnt > 8



The 2nd check of cnt > 8 is redundant as cnt is already checked
and thresholded to a maximum of 8 a few statements earlier.
Remove this redundant 2nd check.

Detected by CoverityScan, CID#114281 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 97adc2b3

drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -488,7 +488,7 @@ static int pvr2_i2c_xfer(struct i2c_adapter *i2c_adap,
		if ((ret > 0) \|\| !(msgs[idx].flags & I2C_M_RD)) {
		if (cnt > 8) cnt = 8;
		printk(KERN_CONT " [");
		for (offs = 0; offs < (cnt>8?8:cnt); offs++) {
		for (offs = 0; offs < cnt; offs++) {
		if (offs) printk(KERN_CONT " ");
		printk(KERN_CONT "%02x",msgs[idx].buf[offs]);
		}