Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 476f5779 authored by Kumar Gala's avatar Kumar Gala
Browse files

[POWERPC] 86xx: Workaround PCI_PRIMARY_BUS usage 



The Freescale PCI-e controllers have an issue in that they use the
PCI_PRIMARY_BUS register in the virtual P2P bridge to determine which
bus number to match on when generating a type 0 config cycle.  The
issue is if we are renumbering bus numbers to match Linux we will try
setting the PCI_PRIMARY_BUS and will not know which bus number to use
for generating type 0 config cycles.  We surpress writing the register
in the P2P bridge and always keep it at zero.

In the future when proper PCI domain support is working we should be
able to remove this.

Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>
parent e4725c23

arch/powerpc/platforms/86xx/pci.c

+3 −1
Original line number Diff line number Diff line
@@ -158,11 +158,13 @@ int __init mpc86xx_add_bridge(struct device_node *dev) 
		printk(KERN_WARNING "Can't get bus-range for %s, assume"

		       " bus 0\n", dev->full_name);



	pci_assign_all_buses = 1;

	hose = pcibios_alloc_controller();

	if (!hose)

		return -ENOMEM;

	hose->arch_data = dev;

	hose->indirect_type = PPC_INDIRECT_TYPE_EXT_REG;

	hose->indirect_type = PPC_INDIRECT_TYPE_EXT_REG |

				PPC_INDIRECT_TYPE_SURPRESS_PRIMARY_BUS;



	hose->first_busno = bus_range ? bus_range[0] : 0x0;

	hose->last_busno = bus_range ? bus_range[1] : 0xff;

arch/powerpc/sysdev/indirect_pci.c

+6 −0
Original line number Diff line number Diff line
@@ -103,6 +103,12 @@ indirect_write_config(struct pci_bus *bus, unsigned int devfn, int offset, 
		 (0x80000000 | (bus_no << 16)

		  | (devfn << 8) | reg | cfg_type));



	/* surpress setting of PCI_PRIMARY_BUS */

	if (hose->indirect_type & PPC_INDIRECT_TYPE_SURPRESS_PRIMARY_BUS)

		if ((offset == PCI_PRIMARY_BUS) &&

			(bus->number == hose->first_busno))

		val &= 0xffffff00;



	/*

	 * Note: the caller has already checked that offset is

	 * suitably aligned and that len is 1, 2 or 4.

include/asm-ppc/pci-bridge.h

+5 −0
Original line number Diff line number Diff line
@@ -73,9 +73,14 @@ struct pci_controller { 
	 * Used for variants of PCI indirect handling and possible quirks:

	 *  SET_CFG_TYPE - used on 4xx or any PHB that does explicit type0/1

	 *  EXT_REG - provides access to PCI-e extended registers

	 *  SURPRESS_PRIMARY_BUS - we surpress the setting of PCI_PRIMARY_BUS

	 *   on Freescale PCI-e controllers since they used the PCI_PRIMARY_BUS

	 *   to determine which bus number to match on when generating type0

	 *   config cycles

	 */

#define PPC_INDIRECT_TYPE_SET_CFG_TYPE		(0x00000001)

#define PPC_INDIRECT_TYPE_EXT_REG		(0x00000002)

#define PPC_INDIRECT_TYPE_SURPRESS_PRIMARY_BUS	(0x00000004)

	u32 indirect_type;



	/* Currently, we limit ourselves to 1 IO range and 3 mem