Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 474675ad authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

V4L/DVB: videobuf-dma-sg: Avoid using a wrong size 



drivers/media/video/videobuf-dma-sg.c: In function ‘__videobuf_mmap_mapper’:
drivers/media/video/videobuf-dma-sg.c:557: warning: ‘size’ may be used uninitialized in this function

The condition where size is floating should never happen, due to the paranoia check,
but a future change at the logic might break it. So, let's just set size to zero and
use it for the paranoia check.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent e4dac289

drivers/media/video/videobuf-dma-sg.c

+2 −2
Original line number Diff line number Diff line
@@ -554,7 +554,7 @@ static int __videobuf_mmap_mapper(struct videobuf_queue *q, 
{

	struct videobuf_dma_sg_memory *mem = buf->priv;

	struct videobuf_mapping *map;

	unsigned int first, last, size, i;

	unsigned int first, last, size = 0, i;

	int retval;



	retval = -EINVAL;
@@ -579,7 +579,7 @@ static int __videobuf_mmap_mapper(struct videobuf_queue *q, 
	}



	/* paranoia, should never happen since buf is always valid. */

	if (VIDEO_MAX_FRAME == first) {

	if (!size) {

		dprintk(1, "mmap app bug: offset invalid [offset=0x%lx]\n",

				(vma->vm_pgoff << PAGE_SHIFT));

		goto done;