Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4722ac3b authored by Keith Busch's avatar Keith Busch Committed by Greg Kroah-Hartman
Browse files

nvme: restrict management ioctls to admin 



commit 23e085b2dead13b51fe86d27069895b740f749c0 upstream.

The passthrough commands already have this restriction, but the other
operations do not. Require the same capabilities for all users as all of
these operations, which include resets and rescans, can be disruptive.

Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarOvidiu Panait <ovidiu.panait@windriver.com>
parent bbfbdca6

drivers/nvme/host/core.c

+6 −0
Original line number Diff line number Diff line
@@ -2675,11 +2675,17 @@ static long nvme_dev_ioctl(struct file *file, unsigned int cmd, 
	case NVME_IOCTL_IO_CMD:

		return nvme_dev_user_cmd(ctrl, argp);

	case NVME_IOCTL_RESET:

		if (!capable(CAP_SYS_ADMIN))

			return -EACCES;

		dev_warn(ctrl->device, "resetting controller\n");

		return nvme_reset_ctrl_sync(ctrl);

	case NVME_IOCTL_SUBSYS_RESET:

		if (!capable(CAP_SYS_ADMIN))

			return -EACCES;

		return nvme_reset_subsystem(ctrl);

	case NVME_IOCTL_RESCAN:

		if (!capable(CAP_SYS_ADMIN))

			return -EACCES;

		nvme_queue_scan(ctrl);

		return 0;

	default: