Commit 46cd49a1 authored Mar 07, 2021 by Jia-Ju Bai Committed by Greg Kroah-Hartman Mar 30, 2021

net: hisilicon: hns: fix error return code of hns_nic_clear_all_rx_fetch()



[ Upstream commit 143c253f42bad20357e7e4432087aca747c43384 ]

When hns_assemble_skb() returns NULL to skb, no error return code of
hns_nic_clear_all_rx_fetch() is assigned.
To fix this bug, ret is assigned with -ENOMEM in this case.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5cd09eea

drivers/net/ethernet/hisilicon/hns/hns_enet.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1677,8 +1677,10 @@ static int hns_nic_clear_all_rx_fetch(struct net_device *ndev)
		for (j = 0; j < fetch_num; j++) {
		/* alloc one skb and init */
		skb = hns_assemble_skb(ndev);
		if (!skb)
		if (!skb) {
		ret = -ENOMEM;
		goto out;
		}
		rd = &tx_ring_data(priv, skb->queue_mapping);
		hns_nic_net_xmit_hw(ndev, skb, rd);