Commit 46c319b8 authored Mar 13, 2017 by Johan Hovold Committed by Wim Van Sebroeck May 18, 2017

watchdog: pcwd_usb: fix NULL-deref at probe



Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

parent ddd6d240

drivers/watchdog/pcwd_usb.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -630,6 +630,9 @@ static int usb_pcwd_probe(struct usb_interface *interface,
		return -ENODEV;
		}

		if (iface_desc->desc.bNumEndpoints < 1)
		return -ENODEV;

		/* check out the endpoint: it has to be Interrupt & IN */
		endpoint = &iface_desc->endpoint[0].desc;