Commit 46977ef9 authored Nov 12, 2020 by Chen Zhou Committed by Greg Kroah-Hartman Nov 18, 2020

selinux: Fix error return code in sel_ib_pkey_sid_slow()



commit c350f8bea271782e2733419bd2ab9bf4ec2051ef upstream.

Fix to return a negative error code from the error handling case
instead of 0 in function sel_ib_pkey_sid_slow(), as done elsewhere
in this function.

Cc: stable@vger.kernel.org
Fixes: 409dcf31 ("selinux: Add a cache for quicker retreival of PKey SIDs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b0f6ea85

security/selinux/ibpkey.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -161,8 +161,10 @@ static int sel_ib_pkey_sid_slow(u64 subnet_prefix, u16 pkey_num, u32 *sid)
		* is valid, it just won't be added to the cache.
		*/
		new = kzalloc(sizeof(*new), GFP_ATOMIC);
		if (!new)
		if (!new) {
		ret = -ENOMEM;
		goto out;
		}

		new->psec.subnet_prefix = subnet_prefix;
		new->psec.pkey = pkey_num;