Commit 4671fc6d authored Sep 15, 2015 by Eric Dumazet Committed by David S. Miller Sep 17, 2015

net/mlx4_en: really allow to change RSS key



When changing rss key, we do not want to overwrite user provided key
by the one provided by netdev_rss_key_fill(), which is the host random
key generated at boot time.

Fixes: 947cbb0a ("net/mlx4_en: Support for configurable RSS hash function")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eyal Perry <eyalpe@mellanox.com>
CC: Amir Vadai <amirv@mellanox.com>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 58189ca7

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1268,8 +1268,6 @@ int mlx4_en_config_rss_steer(struct mlx4_en_priv *priv)
		rss_context->hash_fn = MLX4_RSS_HASH_TOP;
		memcpy(rss_context->rss_key, priv->rss_key,
		MLX4_EN_RSS_KEY_SIZE);
		netdev_rss_key_fill(rss_context->rss_key,
		MLX4_EN_RSS_KEY_SIZE);
		} else {
		en_err(priv, "Unknown RSS hash function requested\n");
		err = -EINVAL;