Commit 46591962 authored Jul 30, 2013 by Xie XiuQi Committed by Ingo Molnar Jul 30, 2013

generic-ipi: Kill unnecessary variable - csd_flags



After commit 8969a5ed
("generic-ipi: remove kmalloc()"), wait = 0 can be guaranteed,
and all callsites of generic_exec_single() do an unconditional
csd_lock() now.

So csd_flags is unnecessary now. Remove it.

Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Link: http://lkml.kernel.org/r/51F72DA1.7010401@huawei.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 323f54ed

kernel/smp.c

+1 −13

Original line number	Diff line number	Diff line
		@@ -186,24 +186,12 @@ void generic_smp_call_function_single_interrupt(void)

		while (!list_empty(&list)) {
		struct call_single_data *csd;
		unsigned int csd_flags;

		csd = list_entry(list.next, struct call_single_data, list);
		list_del(&csd->list);

		/*
		* 'csd' can be invalid after this call if flags == 0
		* (when called through generic_exec_single()),
		* so save them away before making the call:
		*/
		csd_flags = csd->flags;

		csd->func(csd->info);

		/*
		* Unlocked CSDs are valid through generic_exec_single():
		*/
		if (csd_flags & CSD_FLAG_LOCK)
		csd_unlock(csd);
		}
		}