Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45c55e92 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: warn on logging continuations 

pr_cont(...) and printk(KERN_CONT ...) uses should be discouraged
as their output can be interleaved by multiple logging processes.

Link: http://lkml.kernel.org/r/7100ba00098694ec81471a299583ed068975fd05.1483465888.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 77cb8546

scripts/checkpatch.pl

+6 −0
Original line number Diff line number Diff line
@@ -5287,6 +5287,12 @@ sub process { 
			}

		}



# check for logging continuations

		if ($line =~ /\bprintk\s*\(\s*KERN_CONT\b|\bpr_cont\s*\(/) {

			WARN("LOGGING_CONTINUATION",

			     "Avoid logging continuation uses where feasible\n" . $herecurr);

		}



# check for mask then right shift without a parentheses

		if ($^V && $^V ge 5.10.0 &&

		    $line =~ /$LvalOrFunc\s*\&\s*($LvalOrFunc)\s*>>/ &&