Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4587eee0 authored by Steve French's avatar Steve French
Browse files

SMB3: Validate negotiate request must always be signed 



According to MS-SMB2 3.2.55 validate_negotiate request must
always be signed. Some Windows can fail the request if you send it unsigned

See kernel bugzilla bug 197311

CC: Stable <stable@vger.kernel.org>
Acked-by: Ronnie Sahlberg <lsahlber.redhat.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
parent a2d9daad

fs/cifs/smb2pdu.c

+3 −0
Original line number Diff line number Diff line
@@ -1979,6 +1979,9 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, 
	} else

		iov[0].iov_len = get_rfc1002_length(req) + 4;



	/* validate negotiate request must be signed - see MS-SMB2 3.2.5.5 */

	if (opcode == FSCTL_VALIDATE_NEGOTIATE_INFO)

		req->hdr.sync_hdr.Flags |= SMB2_FLAGS_SIGNED;



	rc = SendReceive2(xid, ses, iov, n_iov, &resp_buftype, flags, &rsp_iov);

	cifs_small_buf_release(req);