Commit 44edff1b authored Mar 22, 2018 by Alexandre Belloni Committed by Linus Walleij Mar 26, 2018

pinctrl: ocelot: fix gpio direction



Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for
output. ocelot_gpio_set_direction() got it wrong and this went unnoticed
when the driver was reworked.

Reported-by: Gregory Clement <gregory.clement@bootlin.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent e6c462d3

drivers/pinctrl/pinctrl-ocelot.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev,
		struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);

		regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin),
		input ? BIT(pin) : 0);
		input ? 0 : BIT(pin));

		return 0;
		}